Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake: Fix ScalingPolicy and WarehouseType Refs in WarehouseObjectProperties and use ObjectReferenceSegment in AlterWarehouseStatementSegment #5264

Conversation

moreaupascal56
Copy link
Contributor

@moreaupascal56 moreaupascal56 commented Oct 2, 2023

Brief summary of the change made

As talked in the issue there is 2 distinct issues:

fixes #4937

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@coveralls
Copy link

coveralls commented Oct 2, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling b931279 on moreaupascal56:alter-warehouse-fix-optionnaly-quoted-set into 8e14e5a on sqlfluff:main.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   16743      0   100%

222 files skipped due to complete coverage.

@moreaupascal56 moreaupascal56 changed the title Fix ScalingPolicy and WarehouseType Refs in WarehouseObjectProperties Fix ScalingPolicy and WarehouseType Refs in WarehouseObjectProperties and use ObjectReferenceSegment in AlterWarehouseStatementSegment Oct 2, 2023
@moreaupascal56 moreaupascal56 changed the title Fix ScalingPolicy and WarehouseType Refs in WarehouseObjectProperties and use ObjectReferenceSegment in AlterWarehouseStatementSegment Snowflake: Fix ScalingPolicy and WarehouseType Refs in WarehouseObjectProperties and use ObjectReferenceSegment in AlterWarehouseStatementSegment Oct 2, 2023
Copy link
Contributor

@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@greg-finley greg-finley added this pull request to the merge queue Oct 2, 2023
Merged via the queue into sqlfluff:main with commit 5680394 Oct 2, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALTER WAREHOUSE Snowflaken statements do no support variables or single quotes
3 participants