Snowflake: Fix ScalingPolicy and WarehouseType Refs in WarehouseObjectProperties and use ObjectReferenceSegment in AlterWarehouseStatementSegment #5264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
As talked in the issue there is 2 distinct issues:
ScalingPolicy
andWarehouseType
Refs inWarehouseObjectProperties
: The main issue was that SCALING_POLICY can be quoted (cf ALTER WAREHOUSE Snowflaken statements do no support variables or single quotes #4937) and that was not dealt with.I changed the way SCALING_POLICY works in
WarehouseObjectPropertiesSegment
to mimic howWarehouseSize
is working.Doing that I saw that there is a new WAREHOUSE_TYPE in the snowflake docs (SNOWPARK-OPTIMIZED) so I did the same work for WarehouseType.
Then I udpated the tests accordingly.
NakedIdentifierSegment
byObjectReferenceSegment
inAlterWarehouseStatementSegment
: As said in the issue we can use variable for names (why not) and so I replacedNakedIdentifierSegment
byObjectReferenceSegment
and added a testfixes #4937
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.