Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Make --force deprecation print on stderr #5681

Merged
merged 1 commit into from Mar 16, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Mar 15, 2024

Brief summary of the change made

Removes the deprecation warning from stdout and puts it on stderr. Before, the output would be included in the output file if piping to a file.

fixes #5679

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17337      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link

Coverage Status

coverage: 99.984%. remained the same
when pulling a122d35 on keraion:force_deprecation_stderr
into 5b39b51 on sqlfluff:main.

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Mar 16, 2024
Merged via the queue into sqlfluff:main with commit 9fdf539 Mar 16, 2024
27 checks passed
@keraion keraion deleted the force_deprecation_stderr branch April 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sql FLuff VScode extension on formatting adding a debug line to the top of the sql file
3 participants