New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vertica] fix gaps for some datatypes, complex alias support, fix group by for DDL #5691
Conversation
Coverage Results ✅
|
gpa | ||
FROM students | ||
WHERE major = ARRAY[row('Science', 'Physics')]; | ||
-- Need to add support for complex datatypes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a regression?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's true, but if you try to use row datatype not inside array it will fail because it's not implemented, so it seems better to have more specific array support and later add a row datatype
Current changes in the array segment allow me to parse sections with Jinja like:
select
array[
{% for metric_event in funnel_events %}
{% for window_size in window_sizes %}
null,
{% endfor %}
{% endfor %}
null
]::array[varchar] as agg_data
from tab;
Without new changes, it will violate rule RF06 Missing quoted keyword identifier varchar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible. Thanks for checking into the potential regression, but on balance it seems reasonable for now.
Brief summary of the change made
fixes #5687
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.