Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparkSQL: Support TIMESTAMP_LTZ and TIMESTAMP_NTZ types #5783

Merged

Conversation

padraic00
Copy link
Contributor

Brief summary of the change made

Adds support for new timestamp types introduced in Spark 3.4 SPARK-35662.

Fixes #5538

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Apr 20, 2024
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17551      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link

Coverage Status

coverage: 99.985%. remained the same
when pulling 5bbf0fd on padraic00:sparksql-parse-timestamp-ntz-ltz
into fbf8fad on sqlfluff:main.

Merged via the queue into sqlfluff:main with commit 7435b0d Apr 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support timestamp_ntz datatype for Databricks Dialect
3 participants