Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so this might be a little controversial.
I understand why #5458 was merged - the previous situation didn't work well with dark mode terminals (see #1659 and #1170). However I'm finding that the solution of changing the background is also quite hard to read on some other themes (in particular on powershell), so I've played with a few options, and I think this might be an improvement on both.
This changes the
lightgrey
colour to justlight
and maps it to the ANSI yellow code. It does change the overall feel quite a bit, but I think it's a good compromise. Here's some shots of what it looks like on a few different colour schemes:Ubuntu
Monokai
Solarized
Unfortunately I don't have a mac and so can't confirm exactly what it looks like on MacOS dark solarized as per the original request.
@ryaminal , @louis-vines, @puetsch - as the original posters of the linked issues, are you able to try this variant and confirm whether it's readable on MacOS dark mode? @WittierDinosaur if you're on a Mac, you might also be able to confirm?