Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use an external antlr2 if available #292

Closed
wants to merge 2 commits into from
Closed

cmake: use an external antlr2 if available #292

wants to merge 2 commits into from

Conversation

pinotree
Copy link
Contributor

@pinotree pinotree commented May 3, 2015

Look for an installed antlr v2, and if available use it instead of its embedded copy.

@rp-
Copy link
Contributor

rp- commented May 5, 2015

Thanks so far, just do me a little favor and replace the empty

if(ANTLR2_FOUND)
else()
...

with

if(NOT ANTLR2_FOUND)
...

then I'm happy to merge it

Look for an installed antlr v2, and if available use it instead of its
embedded copy.
Antlr v2 is available in Debian-based systems for many years, so make
use of it instead of the embedded copy of it.
@rp- rp- closed this May 12, 2015
@rp-
Copy link
Contributor

rp- commented May 12, 2015

merged

@pinotree pinotree deleted the external-antlr branch May 12, 2015 19:48
@justinclift
Copy link
Member

Thanks @rp- and @pinotree, that's awesome. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants