Make sure that tests use a predictable time zone. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am curious to know more about your case, maybe it's beneficial for other cases as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that all tests always use the UTC time zone when constructing a
DateTime. This doesn't change the existing tests, but it allows us to reject all 'unpredictable' times in our custom (downstream) Snowflake compiler.This is an example of a change which is needed only for our custom compiler, but which we wouldn't want to keep in a local change on our repository for maintainability reasons. I.e. keeping this as a commit local to our downstream branch would be a constant source of potential merge conflicts, so we would like to upstream this. We'd like to use this as opportunity to discuss how to best handle such changes.