Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow select without table to support cross apply #541

Merged
merged 3 commits into from Mar 4, 2022

Conversation

mnsrulz
Copy link
Contributor

@mnsrulz mnsrulz commented Nov 20, 2021

This PR is addressing some of the issues reported earlier #123 #104

where people want to select some static values or native database functions or to support column reusability of cross/outer apply. The majority of the database provider supports this.

Let me know your thoughts on this one.

@mnsrulz
Copy link
Contributor Author

mnsrulz commented Dec 17, 2021

@ahmad-moussawi would you consider reviewing this and let me know what's your thoughts on this?

@ahmad-moussawi
Copy link
Contributor

@mnsrulz I agree with you regarding omitting the no-table exception.
But I don't want to add an explicit CrossApply since it's the same as LATERAL JOIN in MySql for example,
So I prefer keeping it as an optional parameter where the developer can pass the join type there.

@mnsrulz
Copy link
Contributor Author

mnsrulz commented Dec 19, 2021

Gotcha! I can remove those explicit cross apply and outer apply methods.

@mnsrulz
Copy link
Contributor Author

mnsrulz commented Feb 26, 2022

@mnsrulz I agree with you regarding omitting the no-table exception. But I don't want to add an explicit CrossApply since it's the same as LATERAL JOIN in MySql for example, So I prefer keeping it as an optional parameter where the developer can pass the join type there.

@ahmad-moussawi the pr has been updated. sorry for the late fix.

@ahmad-moussawi ahmad-moussawi merged commit 9554778 into sqlkata:master Mar 4, 2022
@ahmad-moussawi
Copy link
Contributor

@mnsrulz the PR is merged now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants