Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Support window clause using named window #1237

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

iffyio
Copy link
Contributor

@iffyio iffyio commented Apr 27, 2024

BigQuery allows window clause declaration using
either a window spec or a reference to another
named window.
This adds support for the latter.

https://cloud.google.com/bigquery/docs/reference/standard-sql/window-function-calls#ref_named_window

BigQuery allows window clause declaration using
either a window spec or a reference to another
named window.
This adds support for the latter.

https://cloud.google.com/bigquery/docs/reference/standard-sql/window-function-calls#ref_named_window
@coveralls
Copy link

coveralls commented Apr 27, 2024

Pull Request Test Coverage Report for Build 8857999766

Details

  • 38 of 45 (84.44%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 89.239%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/bigquery.rs 1 2 50.0%
src/dialect/generic.rs 1 2 50.0%
src/dialect/mod.rs 1 2 50.0%
tests/sqlparser_common.rs 21 25 84.0%
Totals Coverage Status
Change from base Build 8852365976: -0.004%
Covered Lines: 23494
Relevant Lines: 26327

💛 - Coveralls

@jmhain
Copy link
Contributor

jmhain commented Apr 28, 2024

lgtm! cc @alamb

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @jmhain and @iffyio

I really appreciate that you are helping with reviews (as well as the direct contributions) ❤️

@alamb alamb merged commit 6fcf8c9 into sqlparser-rs:main Apr 30, 2024
10 checks passed
@iffyio iffyio deleted the named-windows branch April 30, 2024 19:50
JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants