This repository has been archived by the owner on Nov 2, 2023. It is now read-only.
agent/backend: use *_PROXY environment variables proxy settings #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #14 +/- ##
==========================================
- Coverage 11.26% 11.02% -0.25%
==========================================
Files 7 7
Lines 1961 1960 -1
==========================================
- Hits 221 216 -5
- Misses 1727 1728 +1
- Partials 13 16 +3
|
Take into account `{HTTPS,HTTP,NO}_PROXY` environment variables (and their
lowercase alternatives) when `SQREEN_PROXY` is not set. This way, the system's
configuration is taken into account when defined.
Users not yet using proxies and not willing to impact their normal http requests
can just use `SQREEN_PROXY` to explicitly tell the agent to use a given proxy.
Replace ginkgo by testify for easier testing (scopes are clearer, parallelism is easier to control, using Go's helpers is easier, etc.).
To debug jenkins fail.
Julio-Guerra
force-pushed
the
feature/standard-proxy-settings
branch
from
93a6ec8
to
440c677
Compare
Julio-Guerra
added a commit
that referenced
this pull request
Jan 24, 2019
- sdk: user-related security events: - ability to associate a user to an event using `WithUserIdentifier()` (#13). - track user creation using `TrackSignup()` (#15). - track user authentication using `TrackAuth()` (#15). - agent/backend: take into account `{HTTPS,HTTP,NO}_PROXY` environment variables (and their lowercase alternatives) (#14). - agent/backend: organization token (#12). - agent/config: avoid conflicts with global viper configs (#16). - sdk: better documentation with examples.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take into account
{HTTPS,HTTP,NO}_PROXYenvironment variables (and their lowercase alternatives) whenSQREEN_PROXYis not set. This way, the system's configuration is taken into account when defined.Users not yet using proxies and not willing to impact their normal http requests can just use
SQREEN_PROXYto explicitly tell the agent to use a given proxy.Closes SQR-5316