Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --source-pr-labels option #236

Merged
merged 4 commits into from
Nov 11, 2020
Merged

Conversation

sorenlouv
Copy link
Owner

Closes #234

@@ -210,7 +210,7 @@ export function getOptionsFromCliArgs(
.option('sourcePRLabels', {
default: configOptions.sourcePRLabels ?? [],
description: 'Add labels to the source (original) PR',
alias: 'sourcePRLabel',
alias: ['sourcePRLabel', 'sourcePrLabel', 'sourcePrLabels'],
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariselseng: this was the culprit: missing aliases.

@sorenlouv sorenlouv merged commit 034e1be into master Nov 11, 2020
@sorenlouv sorenlouv deleted the fix-source-pr-labels-option branch November 11, 2020 07:55
@sorenlouv
Copy link
Owner Author

Released in v5.6.1

@ariselseng
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--source-pr-labels is not working anymore, but --sourcePRLabels works
2 participants