Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge request to fix a bug and some grammar. #5

Merged
merged 7 commits into from
Jan 5, 2020

Conversation

MistakingManx
Copy link
Contributor

@MistakingManx MistakingManx commented Jan 5, 2020

So you don't have to bother with it since I know that developers can be fairly busy, I've forked and fixed a bug that was in your issues and also changed some grammar.

Here is a list of what I changed so you can look at everything if you'd like:

plugin.yml

  • Changed some grammar.
  • Moved the v command into the aliases area so it wouldn't cause issues if another plugin calls it.

VanishV2.php

  • Converted the if cmd name thing to a switch system for easier editing in the future.
  • Added a case switch that makes the command name lowercase, which could possibly make typing /VANISH also work rather than being case sensitive.
  • Moved the broadcast outside the getOnlinePlayers object so it only sends once.
  • Changed the § symbol to use TextFormat due to some computers corrupting the symbol when downloaded.
  • Formatted statements to look better on different editors. (this has no effect).

EventListener.php

  • Formatted statements to look better on different editors. (this has no effect).

VanishV2Task.php

  • Formatted statements to look better on different editors. (this has no effect).

# Use the § symbol for color coding
# Use the § symbol for color coding
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't important to mention in that pull request thing, but I removed a single space from the config file because it bothered me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants