This repository has been archived by the owner on Feb 17, 2020. It is now read-only.
Cleanup #3
Merged
Cleanup #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourlastor
suggested changes
Jan 23, 2018
| @@ -36,9 +36,9 @@ export interface Place { | |||
| export interface Track { | |||
| id: string | |||
| name: string | |||
| accent_color: Optional<string> | |||
There was a problem hiding this comment.
Reminder for tomorrow : this should be using the correct optional
There was a problem hiding this comment.
I'll leave this to you then 👍
| @@ -91,3 +91,16 @@ export const generateSchedule = (firebaseApp: FirebaseApp) => (_: Request, respo | |||
| response.status(200).send('Yay!') | |||
| }) | |||
| } | |||
|
|
|||
| const trackFrom = (rawTrack: TrackData & { id: string } | null): Track | null => { | |||
fourlastor
approved these changes
Jan 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's some outstanding Lint warnings on the code; we also want to get rid of some sketchy variable names on the Android side to map to the Firestore track data, so those snake case fields should be renamed to camel case.
Solution
Address all ESLint warnings (mostly imports); rename the fields for
TrackDatathat are in snake_case to camelCase (a corresponding PR is open on squanchy-android)Test(s) added
No tests — yet!
Paired with
Nobody