Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include system build version in email body #46

Merged
merged 1 commit into from Jul 24, 2020

Conversation

natan
Copy link
Collaborator

@natan natan commented Aug 23, 2017

When bugs are reported from a beta OS, the prefilled email body looked like:

System Version: 11.0

It's useful to be able to determine which beta/build of the OS, and this PR updates it to be:

System: Version 11.0 (Build 15A5361a)

@natan
Copy link
Collaborator Author

natan commented Aug 23, 2017

cc @efirestone @shawnwelch

Copy link
Collaborator

@dfed dfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dig it!

@NickEntin
Copy link
Collaborator

@natan - This change looks great! Do you want to get this rebased and landed? I'm happy to update it for you as well, if that's easier.

@natan natan force-pushed the system-version-with-build branch from 621e2ba to 756a669 Compare July 24, 2020 15:59
@natan natan force-pushed the system-version-with-build branch from 756a669 to b990017 Compare July 24, 2020 16:02
@natan
Copy link
Collaborator Author

natan commented Jul 24, 2020

@natan - This change looks great! Do you want to get this rebased and landed? I'm happy to update it for you as well, if that's easier.

👋 Thanks for taking a look @NickEntin! I just rebased, so this should be good to go.

@NickEntin NickEntin merged commit 38b0c67 into square:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants