Bump iOS Deployment Target to 9 & Fix Deprecations #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JustinDSN! Thanks for your interest in Aardvark 🙂 The changes proposed here would require a major version bump, since we'd be dropping functionality. Can you file an Issue for Xcode 12 support? We'll likely want to roll these changes in with other breaking changes. |
|
Resolves #83 |
NickEntin
reviewed
Aug 19, 2020
NickEntin
reviewed
Aug 19, 2020
|
@JustinDSN If you rebase on master, you should be able to get a green build now using GitHub Actions. There will be some merge conflicts (the change in CI setup and updates to the sample app), but the flaky test has been disabled, so you should see stable builds. |
|
This PR is obsoleted by #92 |
|
Thanks for getting to this @NickEntin fell too far on my todo list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Xcode 12 drops support for iOS 8 deployment target, we need to upgrade Aardvark's deployment target.