ConstrainedAspectRatio element #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdonnelly
reviewed
Oct 24, 2019
watt
force-pushed
the
watt/constrained-aspect-ratio
branch
from
da6eb09
to
076b8d9
Compare
kyleve
approved these changes
Nov 5, 2019
kyleve
reviewed
Nov 5, 2019
| @@ -0,0 +1,77 @@ | |||
| /// Constrains the size of the content element to an aspect ratio. | |||
| public struct ConstrainedAspectRatio: Element { | |||
There was a problem hiding this comment.
Non-blocking: Don't love this name but don't have a better suggestion right now.
kyleve
reviewed
Nov 5, 2019
| public struct ConstrainedAspectRatio: Element { | ||
| /// Represents whether the content element's size should be expanded to fill its parent | ||
| /// or shrunk to fit it. | ||
| public enum ContentMode { |
There was a problem hiding this comment.
Doesnt matter within Blueprint, but I tend to make these enums equatable when I can.
bencochran
approved these changes
Nov 5, 2019
watt
force-pushed
the
watt/constrained-aspect-ratio
branch
from
076b8d9
to
09e1463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
ConstrainedAspectRatioelement that constrains the size of its child to — you guessed it — an aspect ratio.You can choose to enforce this constraint by expanding or shrinking the child. Open to alternative suggestions for the name of "expand or shrink" behavior.