Add keys to Overlay #264
Merged
Add keys to Overlay #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watt
force-pushed
the
watt/overlay-keys
branch
from
95b7f09
to
805f05b
Compare
kyleve
reviewed
Sep 20, 2021
| configure(&self) | ||
| } | ||
|
|
||
| /// Adds the provided element to the overlay. | ||
| @available(*, deprecated, renamed: "add(child:)") |
There was a problem hiding this comment.
IMO keeping this and not deprecating it is probably fine; since not everyone needs/wants keys?
There was a problem hiding this comment.
(Eg, so the shorter method is probably fine to avoid a ton of deprecation warnings)
There was a problem hiding this comment.
meh, stacks use add(child:) and I kinda like the consistency? no strong opinion though
There was a problem hiding this comment.
I thought it was confusing to have both add(_:) and add(child:), and the latter is consistent with other stacks.
kyleve
approved these changes
Sep 20, 2021
kylebshr
approved these changes
Sep 20, 2021
| configure(&self) | ||
| } | ||
|
|
||
| /// Adds the provided element to the overlay. | ||
| @available(*, deprecated, renamed: "add(child:)") |
There was a problem hiding this comment.
meh, stacks use add(child:) and I kinda like the consistency? no strong opinion though
n8chur
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding disambiguation keys to Overlay, like we currently have in other stack-likes.