Size views by their bounds instead of frame #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
entin/clean-up-resizing-methods
to
develop/1.0
January 20, 2021 18:46
The primary behavior difference here affects views that have a non-identity transform applied. There is also a slight behavior difference in that sizing views is now `center`-preserving, rather than `origin`-preserving. This shouldn't affect most idiomatic Paralayout code, since the recommendation is to size views, then align them.
NickEntin
force-pushed
the
entin/size-via-bounds
branch
from
ff2c2ad
to
b69c312
Compare
efirestone
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary behavior difference here affects views that have a non-identity transform applied.
There is also a slight behavior difference in that sizing views is now
center-preserving, rather thanorigin-preserving. This shouldn't affect most idiomatic Paralayout code, since the recommendation is to size views, then align them.This addresses part of #49.