Handle in-progress connections with grace #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I run into this problem all the time. Any chance to get this merged in? |
|
@conradev Can you please make this mergeable? Thanks |
|
Rebased against master |
|
LGTM. Thanks for the contribution! |
wlue
added a commit
that referenced
this pull request
Apr 27, 2013
Handle in-progress connections with grace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, calling
-[PDDebugger forwardAllNetworkTraffic]while there are connections in the process of downloading data will trip an assertion the next time these connections receive a chunk of data and cause the application to crash.This is a small fix to prevent that, by simply ignoring these in-progress connections.