New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemoteNotification should search for values in "aps" dictionary instead of top level. #6
Comments
Are notifications not working for you with SuperDelegate? If not, can you provide specific reproduction steps and a sample remote notification dictionary payload? |
You are supposed to wrap the Unless you're doing something manually, your notification shouldn't sound or show a badge if those keys aren't inside the (At least that's what I understand from the documentation, I also asked in a slack channel and people agree, so I'm not totally crazy.) |
I think you're right re how the server should format the APNS dictionary (I've only done client work, not server work). That said, I'm pretty darned sure we're right on how we're processing RemoteNotifications. @NinoScript, are you not seeing your RemoteNotifications parsed correctly? Or do you think there's a theoretical bug after reading the code? If the former, can you paste in an Square Cash works just fine with badges, notification sounds, etc. So I'm reasonably convinced that we're doing the right thing on our side. But I'm curious what your experience is! |
I'm not seeing RemoteNotifications parsed correctly, this is not theoretical, and the code I posted makes it work. Here's an example of a working remote notification, where the (this was printed inside
I think in your case you're probably re-firing a local notification with that data. Look, here's some random people printing the contents of You'll notice in both cases they access those properties inside |
I'm not firing a local notification (we rarely ever do that). Looking into this. It's possible we missed something since we don't tend to use |
Fix coming for the 0.9 branch shortly! |
0.9.1 has the fix. Waiting for review on 0.8.1. |
0.8.1 has been pushed to cocoapods! |
That's great! Now I can remove my fix and pull the latest version. :) |
I'm not really sure about this, as I'm new to using remote notifications.
But reading the documentation gives me the impression that the
userInfo
dictionary has anaps
dictionary inside with the values.So the RemoteNotification's init should actually look more like this:
At least that seems to work for me, what do you think?
The text was updated successfully, but these errors were encountered: