Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factory generation: lowercase class names #80

Closed
Dkhusainov opened this issue Aug 29, 2020 · 0 comments · Fixed by #83
Closed

Factory generation: lowercase class names #80

Dkhusainov opened this issue Aug 29, 2020 · 0 comments · Fixed by #83
Labels
bug Something isn't working dagger factory Happens when generateDaggerFactories is set to true

Comments

@Dkhusainov
Copy link

Dkhusainov commented Aug 29, 2020 •
edited
Loading 

class myclass @Inject constructor()

This simple reproducer fails inside your codegen with exception.

at com.squareup.kotlinpoet.ClassName$Companion.bestGuess(TypeName.kt:459)
        at com.squareup.anvil.compiler.codegen.dagger.KotlinPoetKt.asClassName(KotlinPoet.kt:37)
        at com.squareup.anvil.compiler.codegen.dagger.InjectConstructorFactoryGenerator.generateFactoryClass(InjectConstructorFactoryGenerator.kt:55)
@vRallev vRallev added bug Something isn't working dagger factory Happens when generateDaggerFactories is set to true labels Aug 30, 2020
vRallev added a commit that referenced this issue Aug 30, 2020
@vRallev
Support classes starting with a lowercase character.
01ae6ed 
Fixes #80
@vRallev vRallev mentioned this issue Aug 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dagger factory Happens when generateDaggerFactories is set to true
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support classes starting with a lowercase character. square/anvil
2 participants
@vRallev @Dkhusainov