Upgrade Dagger #212
Merged
Upgrade Dagger #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that previously failed.
vRallev
commented
Feb 26, 2021
|
|
||
| @Module | ||
| object DaggerModule1 { | ||
| @Provides @Named("") fun provideService(): AssistedService = AssistedService(5, "Hello") |
There was a problem hiding this comment.
That provider method previously triggered an error in Dagger. Without the qualifier the same error happens. Anvil never had this restriction ¯\(ツ)/¯
christiandeange
approved these changes
Feb 26, 2021
| @@ -5,7 +5,7 @@ ext { | |||
| daggerVersion = '2.33' | |||
| espressoVersion = '3.2.0' | |||
| kotlinVersion = project.hasProperty('square.kotlinVersion') ? | |||
| project.getProperty('square.kotlinVersion') : '1.4.30' | |||
| project.getProperty('square.kotlinVersion') : '1.4.31' | |||
There was a problem hiding this comment.
nit: commit message says this updates dagger but this commit only updates the version of kotlin.
There was a problem hiding this comment.
It's actually a 2nd commit that I squeezed in 🙈
0xMatthewGroves
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a test case for an assisted injection scenario that previously failed.