Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP migrate away from BindingModuleGenerator #829

Closed
wants to merge 8 commits into from
Closed

WIP migrate away from BindingModuleGenerator #829

wants to merge 8 commits into from

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Dec 25, 2023 •
edited
Loading

Ref: #751

Current status

  • Reimplemented ContributesBinding code gen to generate these dagger modules directly

TODO

  • Updated tests
  • Update component merging to no longer look for binding hints?
  • Delete BindingModuleGenerator
  • Integrate BindingPriority into component merging
  • Does renameDuplicateFunctions() still have a place?

@ZacSweers
Copy link
Collaborator Author

Superseded by #877

@ZacSweers ZacSweers closed this Feb 26, 2024
@ZacSweers ZacSweers deleted the z/contributesBindingRevamp branch February 26, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ZacSweers