Flow.reloading() should modify the flow in-place #16
Labels
enhancement
New feature or request
Comments
namanjain
pushed a commit
that referenced
this issue
Jun 18, 2020
Bionic uses a logging receiver to receive logs from the subprocesses and log them in the main process. To write the logs in main process, it runs a loop in thread that writes whenever it finds an object in the logging queue used to send over logs from the subprocesses. Instead of continuously looping and checking the logging queue in that thread, we now use a count of listeners on the logging receiver. The loop checks the queue only if there are any active listeners. Aside from minor computing save, this also fixes the issue where when the process ends, receiver thread throws an exception trying to access queue object managed by the manager that stops before killing this daemon thread. #16 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, when you call
Flow.reloading(), you get a new copy of the flow with reloaded state. I think it should also mutate the flow to use the new state.The current behavior is consistent with the other flow methods, which also return new copies rather than modifying the original flow. However, in this case I think the user will pretty much always want the new state, and I often get caught using an out-of-date version of the flow by accident. Since reloading is already a global, magical operation, I'm okay with being a little inconsistent here.
The text was updated successfully, but these errors were encountered: