2nd try: Adds out-name cli option #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mcpherrinm
reviewed
Apr 24, 2018
| @@ -82,6 +83,9 @@ func newCertAction(c *cli.Context) { | |||
| } | |||
|
|
|||
| formattedName := strings.Replace(name, " ", "_", -1) | |||
| if c.IsSet("out-name") { | |||
| formattedName = strings.Replace(c.String("out-name"), " ", "_", -1) | |||
There was a problem hiding this comment.
I think the string replace is potentially confusing and we should omit it. Just do formattedName = out-name. If the user specifies an out-name, we should use it directly.
| @@ -46,6 +46,7 @@ func NewCertRequestCommand() cli.Command { | |||
| cli.StringFlag{"ip", "", "IP address entries for subject alt name (comma separated)", ""}, | |||
| cli.StringFlag{"domain", "", "DNS entries for subject alt name (comma separated)", ""}, | |||
| cli.StringFlag{"key", "", "Path to private key PEM file. If blank, will generate new keypair.", ""}, | |||
| cli.StringFlag{"out-name, on", "", "Name for output files without path and extension. If blank, Common name will be used.", ""}, | |||
Closed
|
there's a few review issues that are lingering here, so we're tackling this in a slightly different way in #81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #52 was closed because I made a lot of changes in cloned master while this request was open. Sorry for that! So this is the next try - now based on a branch. You can decide if it is worth to merge. I made my changes in my clone of your great work now (also experimental PFX export).
Original comment of #52: