Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-array values to be added to Crossfilter #86

Closed
wants to merge 3 commits into from

Conversation

Wildhoney
Copy link

If you pass an object to the add method then it will fail silently. Crossfilter is expecting an array. There are a few solutions that I thought of:

  • Notify the developer if they attempt to add an object;
  • Change the name of the add method to something that implies pluralisation, such as addRecords/addMany;
  • Transform the value into an array if it isn't already;

I chose the last one, but happy to discuss alternatives.

@jkleint
Copy link

jkleint commented Apr 11, 2014

+1; just got bitten by the same problem. Thanks.

@RandomEtc
Copy link
Collaborator

Thanks for your contributions and sorry for silence on this side. As discussed in #151 an active fork is being developed in a new Crossfilter Organization. Please consider rebasing and opening your PR there (if you haven't already) where it should be warmly welcomed by the new maintainers. Cheers!

@RandomEtc RandomEtc closed this Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants