Upgrade Kotlin, AGP and the Gradle wrapper #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vRallev
requested review from
helios175,
patrickyin,
rjrjr and
zach-klippenstein
as code owners
vRallev
commented
Nov 25, 2020
| @@ -14,7 +14,6 @@ android { | |||
| dependencies { | |||
| api deps.recyclerview | |||
|
|
|||
| implementation deps.kotlin_stdlib | |||
There was a problem hiding this comment.
I remove the dependency because the Kotlin Gradle Plugin adds it by default.
zach-klippenstein
approved these changes
Nov 25, 2020
| @@ -306,7 +307,8 @@ private class MutationExtension<T : Any>(val spec: MutationExtensionSpec<T>) : E | |||
|
|
|||
| override lateinit var data: RecyclerData<T> | |||
|
|
|||
| internal fun setUpDragHandle(view: View) { | |||
| @SuppressLint("ClickableViewAccessibility") | |||
| fun setUpDragHandle(view: View) { | |||
There was a problem hiding this comment.
Why make this public? Doesn't seem related.
There was a problem hiding this comment.
It's redundant, because the class itself is private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.