This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Forbid modules who extend from non-Object class types. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (result.containsKey(moduleName)) continue; | ||
| result.put(moduleName, new ArrayList<ExecutableElement>()); | ||
| } else { | ||
| throw new AssertionError(); |
There was a problem hiding this comment.
Was unsure about this. Enforced by @Target on the annotation, right?
There was a problem hiding this comment.
Should I flip the logic?
if (!module.getKind().equals(ElementKind.CLASS)) {
throw new AssertionError();
}
TypeElement moduleType = ...There was a problem hiding this comment.
Ah, I guess it could be on an interface or enum. I'll mark as an error as well.
There was a problem hiding this comment.
Yup. But flipping the logic is good.
|
LGTM |
JakeWharton
added a commit
that referenced
this pull request
Mar 27, 2013
Forbid modules who extend from non-Object class types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188.