This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Fix validation when passing an interface to the injects list. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I admit that this fix is clumsy. The core problem is that the 'injects' list serves double duty: it includes types that we can call ObjectGraph.get() on (could be interfaces) and also types that we call ObjectGraph.inject() on (can't be interfaces). The right fix is to rethink the way Dagger internally tracks and links these keys.
JakeWharton
added a commit
that referenced
this pull request
May 1, 2013
Fix validation when passing an interface to the injects list.
tbroyer
added a commit
to tbroyer/dagger
that referenced
this pull request
Aug 15, 2015
Also make all links to JavaEE javadoc consistent (changed one link from JavaEE 6 to JavaEE 7) Fixes square#222
tbroyer
added a commit
to tbroyer/dagger
that referenced
this pull request
Feb 8, 2016
Same as old issue square#222
tbroyer
added a commit
to tbroyer/dagger
that referenced
this pull request
Feb 11, 2016
Same as old issue square#222
tbroyer
added a commit
to tbroyer/dagger
that referenced
this pull request
Feb 11, 2016
tbroyer
added a commit
to tbroyer/dagger
that referenced
this pull request
Aug 25, 2016
tbroyer
added a commit
to tbroyer/dagger
that referenced
this pull request
Aug 25, 2016
tbroyer
added a commit
to tbroyer/dagger
that referenced
this pull request
Aug 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I admit that this fix is clumsy. The core problem is that
the 'injects' list serves double duty: it includes types that
we can call ObjectGraph.get() on (could be interfaces) and also
types that we call ObjectGraph.inject() on (can't be interfaces).
The right fix is to rethink the way Dagger internally tracks
and links these keys.