Double view restore in Basic Sample?

[rjrjr]

Haven't yet diagnosed if this is a bug in Flow or the sample app, but here's the recipe.

• Launch Basic Sample
• Give your name, hit return
• On the Hello screen, click the increment button a few times
• Without hitting the device back button, swap to another app and then back to the sample.

Notice that the increment has been reset to zero, and that it's being double-painted on the screen over / under the old value.

[rjrjr]

This block in the dispatcher is skipped on pause / resume, so we never remove the current child before putting in the new one. Unclear to me if this is a bug in the sample app or in KeyDispatcher. Seems like something should have short-circuited but didn't.

    if (traversal.origin != null) {
      if (frame.getChildCount() > 0) {
        traversal.getState(traversal.origin.top()).save(frame.getChildAt(0));
        frame.removeAllViews();
      }
    }

[rjrjr]

Oh, derp—KeyDispatcher isn't used here :)