Demo how to do an orientation lock per-screen. #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/disorientationated
branch
from
c78adeb
to
3f58fa9
Compare
|
|
||
| package flow.sample.orientation; | ||
|
|
||
| final class LandscapeScreen { |
There was a problem hiding this comment.
maybe make a Screen interface w/ getLayout() and @Nullable int getRequestedOrientation(), to tidy up the dispatcher a bit.
|
This is nice. A few nits. More importantly I think maybe Flow could take on some of this work to support config changes more easily. Happy to land this first though. |
rjrjr
force-pushed
the
ray/disorientationated
branch
from
3f58fa9
to
084af35
Compare
|
Updated to simplify. Left the isPortrait() method alone, I think anything fancier would be another distraction. I like having all the important parts in one place. |
|
LG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.