Use em dash #226
Merged
Use em dash #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
requested changes
Apr 12, 2017
README.md
Outdated
| @@ -1,10 +1,10 @@ | |||
| # Flow | |||
|
|
|||
| _"Name-giving will be the foundation of our science."_ - Linnaeus | |||
| _"Name-giving will be the foundation of our science."_ —Linnaeus | |||
There was a problem hiding this comment.
Should be pretentious, yes, but should also have consistent spacing. There should either be no leading space before the dash, or there should be a trailing one. I prefer the latter.
Pretentious quotes should be pretentious. (:
|
Just having some fun! Here's a good read: https://en.wikipedia.org/wiki/Dash#En_dash_versus_em_dash |
|
I updated based on your requested changes and signed the agreement, btw. |
rjrjr
approved these changes
Apr 13, 2017
|
I love a good em-dash — I use them all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretentious quotes should be pretentious. (: