Dispatcher javadoc now addresses bootstrapping #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganj
approved these changes
Apr 13, 2017
| * <p> | ||
| * Because of this bootstrapping behavior, Dispatchers are required to be idempotent. They | ||
| * should compare the {@link Flow#getKey(android.view.View) key of the current view(s)} to those | ||
| * in {@link Traversal#destination} before making visible updates. If no update is needed, |
There was a problem hiding this comment.
I'd add some general advice about checking whether the app is already in the correct state for the incoming key (including the getKey check) before making any state changes.
It's possible that an app author might have other state to check/update.
rjrjr
force-pushed
the
ray/boostrap-doc-173
branch
from
2f8b477
to
1517941
Compare
|
PTAL |
rjrjr
force-pushed
the
ray/boostrap-doc-173
branch
from
1517941
to
346c4bc
Compare
In response to confusion expressed in #173
rjrjr
force-pushed
the
ray/boostrap-doc-173
branch
from
346c4bc
to
66cd675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to confusion expressed in #173