Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Flow#updateHistory(HistoryUpdater) #239

Closed
wants to merge 1 commit into from
Closed

Conversation

rjrjr
Copy link
Collaborator

@rjrjr rjrjr commented Apr 14, 2017

In response to the discussion in #197. Allows app code to mutate the history
safely despite the raciness of asynchronous transitions.

@rjrjr
Copy link
Collaborator Author

rjrjr commented Apr 14, 2017

Note that exposing HistoryUpdater.DoSet is very intentional. I have had to replicate that in app code more than once, can't imagine I'm the only one.

In response to the discussion in #197. Allows app code to mutate the history
safely despite the raciness of asynchronous transitions.
@edenman
Copy link
Contributor

edenman commented Apr 14, 2017

I like this alot.

@rjrjr
Copy link
Collaborator Author

rjrjr commented Apr 14, 2017

Offline discussion w/@loganj, we're reluctant to open this up hook without thinking about it a bit more. Is the queue really something we should be exposing even more like this, or would that get in the way of a longer term vision that eliminates the need for it?

@rjrjr rjrjr closed this Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants