Enqueue goBack() calls, because they can come asynchronously. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/backin-it-up-here-boss-195
branch
from
fd561a9
to
01812de
Compare
rjrjr
commented
Apr 14, 2017
flow/src/main/java/flow/Flow.java
Outdated
| @@ -315,13 +336,11 @@ private static History preserveEquivalentPrefix(History current, History propose | |||
|
|
|||
| private enum TraversalState { | |||
| /** {@link PendingTraversal#execute} has not been called. */ | |||
| ENQUEUED, | |||
| /** | |||
| ENQUEUED, /** | |||
rjrjr
force-pushed
the
ray/backin-it-up-here-boss-195
branch
from
01812de
to
0b1f4e1
Compare
|
This has the nice side effect of doing what users will typically expect if they hammer the back button: they'll safely go back to the "first" screen of the app, without crashing or accidentally exiting the app. Then when things calm down, pressing back again will exit the app. LG |
|
I'm going to add one more test case before merging. |
rjrjr
force-pushed
the
ray/backin-it-up-here-boss-195
branch
from
0b1f4e1
to
8a9325b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, apps crash due to popping empty history if goBack()
is called while a transition is outstanding.
Fixes #195. See also discussion in #197.