Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runs our espresso tests on Travis. #245

Closed
wants to merge 1 commit into from
Closed

Conversation

rjrjr
Copy link
Collaborator

@rjrjr rjrjr commented Apr 17, 2017

Addressing #242

@rjrjr
Copy link
Collaborator Author

rjrjr commented Apr 17, 2017

The before_install: block might be redundant. Will try w/o before merging.

@rjrjr
Copy link
Collaborator Author

rjrjr commented Apr 17, 2017

Cool, an actual failure. :/ Working on that.

Should also look into parallel unit and integration test builds, to keep PR feedback loop tight. https://docs.travis-ci.com/user/speeding-up-the-build/

rjrjr added a commit that referenced this pull request Apr 17, 2017
@rjrjr
Copy link
Collaborator Author

rjrjr commented Apr 17, 2017

Fixed the embarrassment, and now seeing the usual Espresso Tests are Flakey misery. I'll dig into that a bit. Might have to back off to adding a line to RELEASING.md reminding us to run the things manually.

@rjrjr
Copy link
Collaborator Author

rjrjr commented Apr 17, 2017

flow.sample.tree.TreeSampleTest#editsAreSaved is flaky. So far only seen it fail when all tests are run, so it comes up after the orientation lock test in MultiKeySampleTest#walkthrough. Not at all certain the orientation lock is actually related, just pointing out the ordering.

@rjrjr
Copy link
Collaborator Author

rjrjr commented Apr 17, 2017

Can reproduce by running the TreeSampleTest itself repeatedly, not a side effect of any other tests. E.g.

  @Test public void one() {
    editsAreSaved();
  }

  @Test public void two() {
    editsAreSaved();
  }

  @Test public void three() {
    editsAreSaved();
  }

rjrjr added a commit that referenced this pull request Apr 17, 2017
rjrjr added a commit that referenced this pull request Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant