Deprecate History#iterator() and History#reverseIterator(). #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explicit methods returning Iterables instead. The raw `iterator` methods on `History` do not make it clear you're iterating from the top or bottom of the stack. Introduced new methods `framesFromTop` and `framesFromBottom` to make it very clear. This also lets you use `for each` loops for both forward and backward iteration. Fix for issue square#261.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raw
iteratormethods onHistorydo not make it clear you're iterating from the top or bottom of the stack. Introduced new methodsframesFromTopandframesFromBottomto make it very clear. This also lets you usefor eachloops for both forward and backward iteration.Fix for issue #261.