Swap the names of framesFromTop and framesFromBottom so they're correct.
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect. I added `framesFromTop` and `framesFromBottom` methods in 03d9578, but the names of the methods were backwards. Follow-up for fix for issue square#261.
zach-klippenstein
force-pushed
the
zachklipp/rename-iteration-methods
branch
from
d1541cb
to
b94f35d
Compare
|
Rebased to use the new AGP version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
framesFromTopandframesFromBottommethods in 03d9578,but the names of the methods were backwards.
Follow-up for fix for issue #261.