Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up build scripts #268

Merged
merged 12 commits into from
Aug 2, 2017
Merged

Tidy up build scripts #268

merged 12 commits into from
Aug 2, 2017

Conversation

jrodbx
Copy link
Collaborator

@jrodbx jrodbx commented Jul 23, 2017

No description provided.

loganj
loganj approved these changes Aug 1, 2017
View reviewed changes
Copy link
Collaborator

@loganj loganj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fantastic to me. It's a big diff though so it'd be great to get another set of eyes on it.

zach-klippenstein
zach-klippenstein approved these changes Aug 2, 2017
View reviewed changes
Copy link
Collaborator

@zach-klippenstein zach-klippenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@rjrjr rjrjr merged commit 530fdf6 into square:master Aug 2, 2017
@jrodbx jrodbx deleted the jrod/cleanup branch August 2, 2017 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganj loganj loganj approved these changes

@zach-klippenstein zach-klippenstein zach-klippenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrodbx @loganj @zach-klippenstein @rjrjr