This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Support certificate chains in headers #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csstaub
requested review from
mcpherrinm,
alokmenghrajani,
mpuncel,
stfinney and
jbpeirce
mpuncel
reviewed
Mar 28, 2018
| leaf := h.certificates[0] | ||
| if opts.Intermediates == nil { | ||
| opts.Intermediates = x509.NewCertPool() | ||
| for _, intermediate := range h.certificates[1:] { |
There was a problem hiding this comment.
is there definitely >=1 intermediate? otherwise this might panic at runtime
There was a problem hiding this comment.
Excellent point I should fix that, there could definitely be zero here
There was a problem hiding this comment.
Oh, actually it's fine: there's at least one element and c[1:] will just be an empty slice:
❯❯❯ gore
gore version 0.2.6 :help for help
gore> c := []string{"test"}
[]string{
"test",
}
gore> c[1:]
[]string{}
There was a problem hiding this comment.
Added some extra test cases to cover this
mpuncel
approved these changes
Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing certificate chains from
x5cheaders in messages, and expose a function to verify & read them. The API here is that we expose a new functionjose.Header#Certificates(opts x509.VerifyOptions)that both reads, verifies & returns the certificate chain a header if present. This forces callers to verify the certificates, which I think is a nice property.