This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
JWS detached (de)serialization #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csstaub
reviewed
May 22, 2019
jws.go
Outdated
| } | ||
|
|
||
| // ParseDetached parses a signed message in compact serialization format with detached payload. | ||
| func ParseDetached(input string, payload []byte) (*JSONWebSignature, error) { |
There was a problem hiding this comment.
Instead of input, call it signature?
There was a problem hiding this comment.
Also would prefer if we error out if payload == nil. Otherwise it's possible to use this function with a non-detached input and nil payload I think, which seems counter-intuitive.
|
Looks good to me. Just left a comment on ParseDetached |
|
@csstaub changed as requested and also renamed the |
csstaub
approved these changes
May 22, 2019
|
@csstaub thanks. If you merge 'v2' into 'master', I'll open a new PR against 'master' to support Go modules and to release v3.0.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @csstaub