Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for build scripts that are renamed from build.gradle #111

Open
changusmc opened this issue Aug 8, 2024 · 0 comments
Open

Add support for build scripts that are renamed from build.gradle #111

changusmc opened this issue Aug 8, 2024 · 0 comments

Comments

@changusmc
Copy link

Hey! Our devs were asking for exactly something like this and I was happy to see it already exists. However, this currently doesn't work for us because we rename all of our build.gradle files to contain the module name e.g. featureBoards.gradle.

This check https://github.com/square/gradle-dependencies-sorter/blob/7496c0a0281bcc61aac8c84db2c80de982efbe20/app/src/main/kotlin/com/squareup/sort/BuildDotGradleFinder.kt could be updated to return filename.endsWith(".gradle") || filename == "build.gradle.kts" and it would work for us.

Locally, I made that change and ran it for our codebase and it only updated our script files. It didn't touch any of our utility or settings files.

If you are willing to consider this change, I'd be happy to put up a PR and update any tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant