-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Since control flow statements often involve a field or local, a format string and variable(s) are likely in the calling code.
- Loading branch information
1 parent
f6a479c
commit c268516
Showing
1 changed file
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c268516
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks backward compatibility. Clients that were compiled against older versions of JavaWriter and that use these methods will get a NoSuchMethodError.
This for example means that I can't upgrade to the newest version of Dagger until other my other dependencies that depend on an old version of JavaWriter have updated to compile against JavaWriter 2.5.
c268516
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, crap. We can add overload without varargs that just pass a
new Object[0]
.