Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a superinterface twice to a TypeSpec causes invalid Java #803

Open
bentatham opened this issue Sep 8, 2020 · 0 comments · May be fixed by #804
Open

Adding a superinterface twice to a TypeSpec causes invalid Java #803

bentatham opened this issue Sep 8, 2020 · 0 comments · May be fixed by #804

Comments

@bentatham
Copy link

We have a case where we are building up a Type and we add interfaces to it based on other content.

Since TypeSpec.Builder.superinterfaces is a List instead of a Set, it allows adding the same interface twice, meaning we have to check if it contains before adding to it.
bentatham added a commit to bentatham/javapoet that referenced this issue Sep 8, 2020
@bentatham
square#803 Use Set for TypeSpec.Builder.superinterfaces
cfb0743
@bentatham bentatham linked a pull request Sep 8, 2020 that will close this issue
Open
bentatham added a commit to bentatham/javapoet that referenced this issue Sep 8, 2020
@bentatham
square#803: only add superinterface once
999fab6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#803 Do not allow duplicates in TypeSpec.Builder.superinterfaces bentatham/javapoet
1 participant
@bentatham