Add iterable overloads for parameterized parameters #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronshapiro
reviewed
Jun 4, 2020
JakeWharton
force-pushed
the
jw/iterables/2020-06-04
branch
from
97b1427
to
f435201
Compare
octylFractal
reviewed
Jun 4, 2020
| for (Type typeArgument : typeArguments) { | ||
| typeArgumentsList.add(typeArgument); | ||
| } | ||
| return get(rawType, typeArgumentsList.toArray(new Type[0])); |
There was a problem hiding this comment.
Doesn't #788 (comment) apply here too? Seems like the same code.
There was a problem hiding this comment.
Ah, NVM -- I see the translation that happens in list().
There was a problem hiding this comment.
Yeah fixing that quickly spirals outward into more of the codebase. I'm happy to pursue such a change, but we can do so separately. Plus, this isn't particularly performance sensitive code so I figured it wasn't worth the effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #727. Closes #781.
This, admittedly, isn't the greatest implementation. But it's the easiest.