This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Use ESLint to ensure uniform and modern JavaScript syntax #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-jose's code has allowed for mixing snake camel case, varying indentation practices etc. I'm sure this could have been addressed with proper jshint config, but having used ESLint in the past, it seems to make a better job at enforcing rules and also auto-fixing small mishaps. I've picked standardjs.com as the basis for the JavaScript style, with one omission -- unlike standardjs, js-jose will still use semicolons everywhere (happy to change it, but seemed like a bigger change that could happen in a separate PR).
alokmenghrajani
approved these changes
Jul 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js-jose's code has allowed for mixing snake camel case, varying
indentation practices etc. I'm sure this could have been addressed with
proper jshint config, but having used ESLint in the past, it seems to
make a better job at enforcing rules and also auto-fixing small mishaps.
I've picked standardjs.com as the basis for the JavaScript style, with
one omission -- unlike standardjs, js-jose will still use semicolons
everywhere (happy to change it, but seemed like a bigger change that
could happen in a separate PR).