Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Commit

Permalink
Wrap socket factory to set Endpoint Identification algo
Browse files Browse the repository at this point in the history
  • Loading branch information
mcpherrinm committed May 10, 2016
1 parent b8bb9fd commit 5a89556
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/*
* Copyright (C) 2016 Square, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package keywhiz.auth.ldap;

import java.io.IOException;
import java.net.InetAddress;
import java.net.Socket;
import javax.net.SocketFactory;
import javax.net.ssl.SSLParameters;
import javax.net.ssl.SSLSocket;
import javax.net.ssl.SSLSocketFactory;

/** This class wraps an SSLSocketFactory and sets the Endpoint Identification algorithm to
* LDAP. This is important for connecting to TLS through a load balancer, where we may see
* different certs, triggering Java8's 3shake mitigation */
final class EndpointIdentificationSocketFactory extends SocketFactory {
private final SSLSocketFactory factory;

EndpointIdentificationSocketFactory(SSLSocketFactory factory) {
this.factory = factory;
}

private Socket setEndpoint(Socket socket) {
SSLSocket sslSocket = (SSLSocket)socket;
SSLParameters parameters = sslSocket.getSSLParameters();
parameters.setEndpointIdentificationAlgorithm("LDAPS");
sslSocket.setSSLParameters(parameters);
return sslSocket;
}

@Override
public Socket createSocket(String host, int port) throws IOException {
return setEndpoint(factory.createSocket(host, port));
}

@Override
public Socket createSocket(String host, int port, InetAddress localAddress, int localPort)
throws IOException {
return setEndpoint(factory.createSocket(host, port, localAddress, localPort));
}

@Override
public Socket createSocket(InetAddress inetAddress, int port) throws IOException {
return setEndpoint(factory.createSocket(inetAddress, port));
}

@Override
public Socket createSocket(InetAddress inetAddress, int port, InetAddress localAddress, int localPort)
throws IOException {
return setEndpoint(factory.createSocket(inetAddress, port, localAddress, localPort));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.unboundid.util.ssl.SSLUtil;
import com.unboundid.util.ssl.TrustStoreTrustManager;
import java.security.GeneralSecurityException;
import javax.net.SocketFactory;

public class LdapConnectionFactory {
private final String server;
Expand Down Expand Up @@ -52,7 +53,8 @@ public LDAPConnection getLDAPConnection(String userDN, String password)
LDAPConnectionOptions options = new LDAPConnectionOptions();
options.setSSLSocketVerifier(new HostNameSSLSocketVerifier(false));
SSLUtil sslUtil = new SSLUtil(trust);
LDAPConnection ldapConnection = new LDAPConnection(sslUtil.createSSLSocketFactory("TLSv1.2"), options);
SocketFactory factory = new EndpointIdentificationSocketFactory(sslUtil.createSSLSocketFactory("TLSv1.2"));
LDAPConnection ldapConnection = new LDAPConnection(factory, options);

// Connect, retrieve the DN of the user (if any)
ldapConnection.connect(server, port);
Expand Down

0 comments on commit 5a89556

Please sign in to comment.