Reducing expired secrets fetch cost by 25%

square · Dec 8, 2022 · 816f61c · 816f61c
1 parent 59ecbe5
commit 816f61c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/server/src/main/java/keywhiz/service/daos/SecretSeriesDAO.java b/server/src/main/java/keywhiz/service/daos/SecretSeriesDAO.java
@@ -253,6 +253,7 @@ public List<SecretSeries> getMultipleSecretSeriesByName(List<String> names) {
   public ImmutableList<SecretSeries> getSecretSeries(@Nullable Long expireMaxTime,
       @Nullable Group group, @Nullable Long expireMinTime, @Nullable String minName,
       @Nullable Integer limit) {
+
     Table<SecretsContentRecord> secretsContentTable = SECRETS_CONTENT;
     if (expireMaxTime != null && expireMaxTime > 0) {
       // Force this join to use the index on the secrets_content.expiry
@@ -263,7 +264,7 @@ public ImmutableList<SecretSeries> getSecretSeries(@Nullable Long expireMaxTime,
     }
 
     SelectQuery<Record> select = dslContext
-          .select()
+          .select(SECRETS.fields())
           .from(SECRETS)
           .join(secretsContentTable)
           .on(SECRETS.CURRENT.equal(SECRETS_CONTENT.ID))