This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Compare HMACs with MessageDigest to avoid timing attacks #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavanyaharinarayan
requested review from
a team,
jdtw,
captiosus and
mmontgomery-square
|
|
jdtw
approved these changes
Apr 14, 2022
| * | ||
| * Uses MessageDigest to prevent timing attacks. | ||
| * */ | ||
| public boolean compareHmacs(String left, String right) { |
There was a problem hiding this comment.
I don't know Java well, so I might be totally off base here, but can/should this method be static since it doesn't need to use any of the class members?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.equals is vulnerable to timing attacks.