This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
added OwnershipPermissionCheck #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violetd12
requested review from
a team,
jdtw,
mweissbacher,
stfinney and
mmontgomery-square
server/src/main/java/keywhiz/service/permissions/OwnershipPermissionCheck.java
Outdated
Show resolved
Hide resolved
server/src/main/java/keywhiz/service/permissions/OwnershipPermissionCheck.java
Outdated
Show resolved
Hide resolved
| public boolean isAllowed(Object source, String action, Object target) { | ||
| boolean hasPermission = false; | ||
|
|
||
| if (isClient(source) && isSecret(target)) { |
There was a problem hiding this comment.
Awesome, super readable.
|
|
||
| if (isClient(source) && isSecret(target)) { | ||
| Set<Group> clientGroups = aclDAO.getGroupsFor((Client) source); | ||
| String secretOwner =((Secret) target).getOwner(); |
There was a problem hiding this comment.
We should really get Checkstyle going for this project, but in the meantime make sure you always put a space on both sides of an equal sign.
There was a problem hiding this comment.
there is. just realized that the style guide warned me about the if statement simplification for the help functions. but not the spacing
server/src/main/java/keywhiz/service/permissions/OwnershipPermissionCheck.java
Outdated
Show resolved
Hide resolved
violetd12
commented
Jun 24, 2022
| public void testIsAllowedWhenSourceIsNotAClient() { | ||
| boolean permitted = ownershipPermissionCheck.isAllowed(USER, Action.CREATE, SECRET_WITH_OWNER); | ||
|
|
||
| assertThat(permitted).isEqualTo(false); |
There was a problem hiding this comment.
Had to make this explicitly equal to false because it appears that assertThat(permitted) always returns true
mmontgomery-square
approved these changes
Jun 27, 2022
violetd12
force-pushed
the
violet/cism-3873_OwnershipPermissionCheck
branch
from
35fa9ae
to
f6fc1e6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.